Feat(eos_cli_config_gen): Add support for unix-socket protocol #4898
+597
−579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4898
# Activate the virtual environment
source test-avd-pr-4898/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/KrasenKolev/avd.git@Add_support_for_unix_socket_protocol#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/KrasenKolev/avd.git#/ansible_collections/arista/avd/,Add_support_for_unix_socket_protocol --force
# Optional: Install AVD examples
cd test-avd-pr-4898
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
role: eos_cli_config_gen
carlbuchmann
changed the title
|
@KrasenKolev thank you for the contribution. CI is failing due to modifying a documentation template that impacts all molecule scenarios. To execute all the molecule scenarios, run |
ClausHolbechArista
previously requested changes
Jan 21, 2025
@ClausHolbechArista, right, after container rebuild everything looks good. |
MaheshGSLAB
reviewed
Jan 22, 2025
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/management-api-http.j2
Outdated
Show resolved
Hide resolved
ClausHolbechArista
dismissed
their stale review
fixed the requested upgrade of anta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add support for unix-socket protocol under management api http-commands
Related Issue(s)
Fixes #4761
Component(s) name
arista.avd.eos_cli_config_genProposed changes
add unix-socket protocol under management api http-commands
How to test
Checklist
User Checklist
Repository Checklist